Remove deprecated APIs in Limelight code - #115
Merged
Merged
Conversation
kcooney
marked this pull request as ready for review
January 11, 2026 01:12
kcooney
force-pushed
the
kcooney/deprecated-limelight
branch
from
January 11, 2026 03:31
74e4ac9 to
9c515a8
Compare
kcooney
force-pushed
the
kcooney/deprecated-limelight
branch
from
January 15, 2026 02:27
9c515a8 to
747ed51
Compare
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
Collaborator
There was a problem hiding this comment.
This looks good, but we should re-evaluate the test cases and make sure all the tests test something useful. I believe we still should be able to get the latency in some way, and if we can, the tests should be modified to ensure they line up
kcooney
force-pushed
the
kcooney/deprecated-limelight
branch
3 times, most recently
from
February 1, 2026 09:26
64733b8 to
6820d51
Compare
kcooney
force-pushed
the
kcooney/deprecated-limelight
branch
from
February 1, 2026 21:06
6820d51 to
ffc1b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix problems found via IntelliJ IDEA Inspection Results.