Remove PersistedConfiguration support for Supplier<{Boolean,Integer,Long,Double}> - #114
Merged
Merged
Conversation
kcooney
force-pushed
the
kcooney/persisted-configuration-suppliers
branch
2 times, most recently
from
January 10, 2026 20:30
575f190 to
cf1a708
Compare
kcooney
marked this pull request as ready for review
January 10, 2026 20:32
kcooney
force-pushed
the
kcooney/persisted-configuration-suppliers
branch
from
January 10, 2026 20:49
cf1a708 to
f6cd704
Compare
kcooney
changed the title
kcooney
changed the title
kcooney
force-pushed
the
kcooney/int-preferences
branch
from
January 15, 2026 02:25
f6499ee to
02c0739
Compare
kcooney
force-pushed
the
kcooney/persisted-configuration-suppliers
branch
from
January 15, 2026 02:26
f6cd704 to
05c0362
Compare
kcooney
force-pushed
the
kcooney/persisted-configuration-suppliers
branch
from
February 1, 2026 02:58
05c0362 to
92d8fe5
Compare
cuttestkittensrule
approved these changes
Feb 1, 2026
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
Collaborator
There was a problem hiding this comment.
There is a minor doc fix that should be done, but other than that, it looks good to go
This reduces complexity in the PersistedConfiguration code. Users can still use BooleanSupplier, IntegerSupplier, LongSupplier, DoubleSupplier or Supplier<String>.
kcooney
force-pushed
the
kcooney/persisted-configuration-suppliers
branch
from
February 1, 2026 03:10
246101b to
bcbda35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces complexity in the PersistedConfiguration code.
Users can still use BooleanSupplier, IntegerSupplier, LongSupplier,
DoubleSupplier or Supplier.
Also rename "factory" to "fetcher" (to make the intent more clear).