Attempt to fix crashes in NetworkTableInstance.close() - #111
Merged
Conversation
kcooney
changed the title
kcooney
force-pushed
the
kcooney/work-around-8215
branch
2 times, most recently
from
January 4, 2026 22:18
63df9e8 to
d555eb6
Compare
- Update `IsolatedNetworkTablesExtension.afterEach()` to remove the instance from the store (so JUnit does not try to close it) The crashes are nondeterministic, so it's hard to tell if these changes will eliminate the crashes in our GitHub action runs.
kcooney
force-pushed
the
kcooney/work-around-8215
branch
from
January 5, 2026 02:25
d555eb6 to
683129d
Compare
kcooney
requested review from
cuttestkittensrule
and removed request for
vdikov
January 10, 2026 18:45
cuttestkittensrule
approved these changes
Jan 10, 2026
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. Out of curiosity, why is the default network table retrieved in IsolatedPreferences#before()? It seems to effectively do nothing...
Contributor
Author
I wanted to make sure the default network table instance is always created before anything else. Probably not needed, but wanted to reduce changes of ordering changes affecting test behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waitForListenerQueue()IsolatedNetworkTablesExtension.afterEach()to remove the instancefrom the store (so JUnit does not try to close it)
The crashes are nondeterministic, so it's hard to tell if these changes will
eliminate the crashes in our GitHub action runs.