Store int preferences as NetworkTableType.kInteger - #109
Merged
Conversation
kcooney
marked this pull request as ready for review
January 4, 2026 04:10
kcooney
force-pushed
the
kcooney/int-preferences
branch
5 times, most recently
from
January 4, 2026 05:25
4615320 to
fd5ef86
Compare
kcooney
force-pushed
the
kcooney/int-preferences
branch
5 times, most recently
from
January 4, 2026 22:01
7ba5c66 to
f6499ee
Compare
kcooney
force-pushed
the
kcooney/int-preferences
branch
from
January 15, 2026 02:25
f6499ee to
02c0739
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Java
Preferencesclass stores int preferences as kDouble (the C++ PreferencesAPI does not do this). This could lead to precision issues, and may confuse users
who try to modify values in the UI.
This change updates
PersistedConfigurationto store int values using kInteger.