Skip to content

PersistedConfiguration now registers classes under the temp NTInstance #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcooney merged 1 commit into from
Dec 29, 2025
Merged

PersistedConfiguration now registers classes under the temp NTInstance #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/main/java/com/team2813/lib2813/preferences/PersistedConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private static <T extends Record> T fromPreferences(
validatePreferenceName(preferenceName);

// TODO: Use Preferences.getNetworkTable() once there is a release of WPILib that includes it.
NetworkTableInstance ntInstance = NetworkTableInstance.getDefault();
NetworkTableInstance ntInstance = Preferences.getNetworkTable().getInstance();
verifyNotRegisteredToAnotherClass(ntInstance, preferenceName, recordClass);

try {
Expand Down
6 changes: 4 additions & 2 deletions lib/src/test/java/com/team2813/lib2813/preferences/PersistedConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

import edu.wpi.first.networktables.NetworkTable;
import edu.wpi.first.networktables.NetworkTableEntry;
import edu.wpi.first.networktables.NetworkTableInstance;
import edu.wpi.first.networktables.NetworkTableType;
import edu.wpi.first.networktables.Topic;
import edu.wpi.first.wpilibj.DataLogManager;
Expand Down Expand Up @@ -173,7 +172,10 @@ public void preferenceNameMapsToOnlyOneRecordType() {

// Assert: topic added under "/PersistedConfiguration", and is not persistent
NetworkTable table =
NetworkTableInstance.getDefault().getTable(REGISTERED_CLASSES_NETWORK_TABLE_KEY);
isolatedPreferences
.getPreferencesTable()
.getInstance()
.getTable(REGISTERED_CLASSES_NETWORK_TABLE_KEY);
NetworkTableEntry entry = table.getEntry(preferenceName);
assertThat(entry.exists()).isTrue();
assertThat(entry.isPersistent()).isFalse();
Expand Down
Loading