Update WPILibExtension to call stepTiming() after each simulated loop - #100
Merged
Conversation
Collaborator
|
Re-running the CI real quick since the HAL crashed due to the race condition again. |
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
Collaborator
There was a problem hiding this comment.
This looks good, but just to make sure this doesn't break any tests, I am going to test this against some of our code that uses this in testing
kcooney
force-pushed
the
kcooney/simulator-advance-clock
branch
from
December 1, 2025 06:45
ffe9ce2 to
d606116
Compare
cuttestkittensrule
approved these changes
Dec 1, 2025
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
Collaborator
There was a problem hiding this comment.
Tested in on our 2025 robot code, and it seems to work fine. One thing that we should consider before merging is if we want to sleep for a different time based on how much has elapsed.
kcooney
force-pushed
the
kcooney/simulator-advance-clock
branch
from
December 1, 2025 17:00
d606116 to
d4af35c
Compare
kcooney
force-pushed
the
kcooney/simulator-advance-clock
branch
from
December 1, 2025 17:02
d4af35c to
0638081
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.