Move SwaggerUI rendering to an SDC#124
Draft
GaborSzanto85 wants to merge 1 commit into
Draft
Conversation
mxr576
reviewed
Apr 9, 2026
| ], | ||
| ], | ||
| ], | ||
| '#type' => 'component', |
Collaborator
There was a problem hiding this comment.
This change likely bypasses the original theme hook execution flow, including preprocess functions and any related logic. As a result, it introduces a breaking change and would normally require a 5.x release.
Is there a way to preserve backward compatibility, or provide a fallback, so existing implementations relying on these hooks continue to work?
Collaborator
There was a problem hiding this comment.
Test changes also indicates to me that simple CSS tweaks on downstream projects could become broken after this change due to CSS selector changes.
mxr576
force-pushed
the
move_rendering_to_sdc
branch
from
b6153f4 to
019c9ad
Compare
mxr576
force-pushed
the
move_rendering_to_sdc
branch
from
019c9ad to
2054b1c
Compare
Collaborator
|
Other than these concerns, I love to see this change! \o/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.