Skip to content

bug: #258 jsx shadow root detection using wrong source input contents #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thescientist13 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug: #258 jsx shadow root detection using wrong source input contents #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/jsx-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ export function parseJsx(moduleURL) {
// TODO: (good first issue) find a more AST (visitor) based way to check for this
// https://github.com/ProjectEvergreen/wcc/issues/258
hasShadowRoot =
moduleContents.slice(node.body.start, node.body.end).indexOf('this.attachShadow(') > 0;
result.code.slice(node.body.start, node.body.end).indexOf('this.attachShadow(') > 0;

for (const n1 of node.body.body) {
if (n1.type === 'MethodDefinition') {
Expand Down Expand Up @@ -773,6 +773,7 @@ export function parseJsx(moduleURL) {
) {
// TODO: do we even need this filter?
const trackingAttrs = observedAttributes.filter((attr) => typeof attr === 'string');
// TODO: should we append cleanup functions if user has their own disconnected callback?
const disconnectedCallbackContents = hasDisconnectedCallback
? ''
: `
Expand Down
Loading