fix C23 compatibility for getenv/getopt prototypes#97
Open
codingWiz-rick wants to merge 1 commit into
Open
Conversation
GCC 15 defaults to C23, which no longer supports unprototyped function declarations (K&R style). This fixes conflicts with strict prototypes in modern C libraries like musl. Build-tested in Buildroot using musl libc and C23. Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
codingWiz-rick
force-pushed
the
fix-c23-prototypes
branch
from
1782ea5 to
3597d66
Compare
Member
|
Thank you for your contribution! Though from a older version, both these files are from original gcc sources. src/getopt_long.c https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libiberty/getopt.c;h=3b6e35946e10c804e274926b3c252c3d0ca12507;hb=HEAD The changes for src/getopt_long.c can be merged as it does not change the behavior of library for incompatible API declarations. |
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 29, 2026
GCC 15 defaults to C23, which removes support for K&R-style unprototyped function declarations. This causes build failures with strict modern C libraries. Add proper function prototypes for getopt, getopt_long, getopt_long_only, getenv, and _getopt_internal to comply with C23 requirements. Fixes build with musl libc and GCC 15. Upstream: Project-OSS-Revival/enca#97 Fixes: https://autobuild.buildroot.net/results/982831f380ba21a28d4a9a0cb100d055771898e2/ Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 29, 2026
GCC 15 defaults to C23, which removes support for K&R-style unprototyped function declarations. This causes build failures with strict modern C libraries. Add proper function prototypes for getopt, getopt_long, getopt_long_only, getenv, and _getopt_internal to comply with C23 requirements. Fixes build with musl libc and GCC 15. Upstream: Project-OSS-Revival/enca#97 Fixes: https://autobuild.buildroot.net/results/982831f380ba21a28d4a9a0cb100d055771898e2/ Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 15 defaults to C23, which no longer supports unprototyped function declarations (K&R style). This fixes conflicts with strict prototypes in modern C libraries like musl.
Build-tested in Buildroot using musl libc and C23.
Files Modified