chore: delete unused data files releaseTimeline.js and features.js#399
Open
mesutoezdil wants to merge 1 commit into
Open
chore: delete unused data files releaseTimeline.js and features.js#399mesutoezdil wants to merge 1 commit into
mesutoezdil wants to merge 1 commit into
Conversation
Both files were never imported by any component or page. Leaving dead exports in src/data/ creates confusion about what data is actually used on the site. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mesutoezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two data files in
src/data/were never imported by any component or page:src/data/features.js- legacy feature list with JSX<Translate>calls, replaced byvalueCards.jssrc/data/home/releaseTimeline.js- milestone data with no consumerLeaving orphaned exports in
src/data/is misleading - it suggests contentthat does not actually appear on the site.