fix: InputModal buttons not visible on TV for TV settings#293
Merged
ProdigyV21 merged 1 commit intoJun 3, 2026
Merged
Conversation
- Replace hardcoded formMaxHeight tiers with screen-aware maxDialogHeight (88% of screen height, capped at 660dp) so the dialog never overflows small-density TV screens - Change scrollable form Column from heightIn(max=...) to weight(1f, fill=false) so header/paste/cancel/confirm buttons are always measured and visible - Replace hardcoded approxFieldHeightPx=260 scroll logic with proportional distribution across formScrollState.maxValue — density-independent and adapts to the actual form height - Add maxLines=1 + TextOverflow.Ellipsis to Paste button text to prevent label clipping on narrow screens Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chillpill244
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formMaxHeighttiers andheightIn(max=660dp)with a screen-aware cap (screenHeight × 0.88, capped at 660dp), and changing the scrollable form toweight(1f, fill=false)so the header and action buttons are always measured and pinned as visible.approxFieldHeightPx = 260that was uncalibrated for different screen densities, causing fields 2 and 3 to scroll out of view. Replaced with a proportional distribution acrossformScrollState.maxValue— density-independent and adapts to the actual form height.maxLines = 1+TextOverflow.Ellipsisto the paste button label so long field names truncate gracefully instead of being sharply cut off.Test plan
…on a narrow screen🤖 Generated with Claude Code