FOUR-31148: Fix group permission authorization#8827
Open
eiresendez wants to merge 3 commits into
Open
Conversation
58f4017 to
bd026ef
Compare
bd026ef to
03bd513
Compare
Contributor
Author
|
Hi @CarliPinell when you have a chance, could you please take a look at this PR? It’s not a high priority ticket — just part of the Maniac Monday issues, so no rush. cc: @sanjacornelius |
|
Contributor
|
QA server K8S was successfully deployed https://ci-9756d86e2f.engk8s.processmaker.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Issue & Reproduction Steps
A user without direct permissions but with inherited group permissions for viewing, creating, editing, and deleting groups can open Admin > Groups > Edit Group > Group Permissions. When that user attempts to assign all permissions to a group and save, the UI shows "This action is unauthorized" because
PUT /api/1.0/permissionsreturns 403.Solution
PermissionController::updateso it checks the requested target entity.edit-userswhen updating user permissions andedit-groupswhen updating group permissions.user_idorgroup_id.How to Test
vendor/bin/phpunit tests/Feature/Api/PermissionsTest.phpedit-groupsbut noedit-users, open Admin > Groups > Edit Group > Group Permissions, assign permissions, and save successfully.Related Tickets & Packages
ci:deploy
.