docs(coding-agent): advisor, prompt-settlement, and ask-user architecture docs - #1448
Closed
DankerMu wants to merge 1 commit into
Closed
docs(coding-agent): advisor, prompt-settlement, and ask-user architecture docs#1448DankerMu wants to merge 1 commit into
DankerMu wants to merge 1 commit into
Conversation
…itecture docs Add three architecture design docs, split along delivery boundaries: - advisor-architecture.md: root-runtime-owned read-only reviewer subruntime (read/grep/glob/git_read via a new thin FileSystemView), candidate-terminal-triggered reviews, severity routing, bounded correction loops with a prompt-admission sealing rule, fail-closed enable / fail-open runtime faults. - prompt-settlement.md: session-level PromptSettlementTracker and structured PromptOutcome across all entry modes; agent_end stays a run-level event, settlement is a separate contract. - ask-user.md: universal ask_user session capability with live responders, persistent fallback pending queues, and a shared TUI editor-surface FIFO dialog arbiter. Also register the docs (and the existing continual-harness roadmap) in docs.json and index.md navigation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Hi @DankerMu, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/PrimeIntellect-ai/prime-agent/blob/main/CONTRIBUTING.md for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three architecture design docs (status: direction accepted, pre-implementation), split along delivery boundaries so each can be reviewed and shipped independently:
read/grep/glob/git_readover a new thinFileSystemView), candidate-terminal-triggered reviews, severity routing (nit/concern/blocker), bounded correction loops with a prompt-admission sealing rule, fail-closed enable / fail-open runtime faults.PromptSettlementTracker+ structuredPromptOutcomeacross TUI/Print/JSON/RPC/ACP;agent_endkeeps its run-level meaning, settlement becomes a separate contract (also fixes the semantics gap where RPCpromptAndWaitresolves on the firstagent_end).ask_usersession capability: live responders in-run, persistent fallback pending queues withneeds_user_inputoutcomes, and a shared TUI editor-surface FIFO dialog arbiter (fixes an existing dialog-clobbering hazard).All source-code contract claims in the docs were verified against the current tree (section 20 of each doc). Delivery is planned as six independently verifiable slices (arbiter → settlement → ask_user ∥ advisor core → TUI/daemon surface → persistence/ops).
Also registers the new docs (plus the existing continual-harness roadmap page) in
docs.jsonandindex.mdnavigation.Notes
🤖 Generated with Claude Code
Note
Add architecture docs for Advisor, Prompt Settlement, and
ask_userto coding-agentAdds three architecture design documents to the coding-agent docs:
SessionAdvisorManager, and phased rollout plan.promptIdlineage across retries, thePromptOutcomecontract, and per-mode behavior including exit code 2 forneeds_user_inputin Print mode.ask_usercapability contract,UserInputBrokerarchitecture, TUI pending queue/FIFO dialog arbiter, daemon multi-responder semantics, persistence/recovery, and phased rollout.Macroscope summarized 698c231.