fix(mcp): make cleanup failures observable - #1264
Closed
sethkarten wants to merge 14 commits into
Closed
Conversation
7 tasks
sethkarten
marked this pull request as ready for review
August 12, 2026 06:00
…bservable-mcp-cleanup
…bservable-mcp-cleanup
…bservable-mcp-cleanup
sethkarten
force-pushed
the
core06-observable-mcp-cleanup
branch
from
August 12, 2026 18:34
ca1c780 to
c01a125
Compare
This was referenced Aug 13, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core-06: observable MCP cleanup failures
Draft publication for stack visibility.
Scope
Validation
sdk-mcp-boundary.test.tsmissinginvokeHostRequest); remediation is proceeding append-only on feat(core): enforce project MCP trust boundaries #1263.Parent: Core-05 #1263 at
6e8e33c484a26498d41022accd5f118ebe7822fcHead:
1fc9d92c3682f98fe672d9cf812ac44a6dcded3aNote
Make MCP cleanup failures observable
Adjusts blank line formatting in the MCP cleanup code with no functional changes.
Macroscope summarized 940ce7f.
Note
Low Risk
Intended scope is observability and tests around MCP teardown, not auth or declaration admission; risk rises only if close-path behavior changes beyond logging/reporting.
Overview
Core-06 incremental delta on the MCP declaration/runtime stack (parent Core-05): make MCP session close / cleanup failures observable instead of failing silently, using redacted error detail so operators can see that teardown failed without leaking secrets.
The PR description also calls for focused regression coverage around MCP probe / declaration cleanup paths. The diff snapshot provided for this review contained no file changes, so line-level verification should be done on the branch head (
1fc9d92); an earlier automated pass on a nearby commit reported whitespace-only edits in MCP cleanup code.Reviewed by Cursor Bugbot for commit 940ce7f. Bugbot is set up for automated code reviews on this repo. Configure here.