-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(acp): preserve causal prompt correlation #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6dd9e86
feat(acp): preserve causal prompt correlation
sethkarten c2c370a
fix(acp): preserve terminal and admission lifecycle truth
sethkarten 4529165
test(acp): type lifecycle regression fixtures
sethkarten 46613b4
fix(acp): stabilize lifecycle regressions
sethkarten c4d710c
style(acp): align lifecycle regression fixture
sethkarten 759f295
merge(acp): restack P2 on main-based P1
sethkarten 7698c7d
fix(acp): preserve connection-scoped child origins
sethkarten 86526a3
fix(acp): settle terminal producer lifecycle
sethkarten 656dd21
test(acp): assert sanitized terminal failure
sethkarten 6f81455
fix(acp): recover update queue after publish failures
sethkarten 0915d0c
Merge commit 'dc6f1a8a774f6295f4591e2f01422090b57fa832' into fix/revi…
sethkarten 28b42c2
fix(acp): retain nested work through parent deletion
sethkarten dd035db
fix(agent): add intercept relay identity
sethkarten f61d609
fix(coding-agent): avoid duplicate intercepted retries
sethkarten b588c5b
fix(agent): type relay stream test callbacks
sethkarten 6998301
fix(coding-agent): contain intercept auth retries
sethkarten 58f9a05
test(coding-agent): await process teardown before cleanup
sethkarten 60e5994
fix(release): exclude local Python caches
sethkarten cbdff0b
feat(cli): add exact socket daemon shutdown
sethkarten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exact shutdown succeeds on missing socket
High Severity
The exact-shutdown catch treats any failure as success whenever
existsSync(socketPath)is false. That is not a reliable “daemon gone” signal: Windows named pipes typically do not appear as files, and a refused unverified daemon still running after a handshake error is reported as stopped. Callers then skip shutdown and can proceed as if the process had exited.Reviewed by Cursor Bugbot for commit cbdff0b. Configure here.