TE: migrate BOCountriesPage to Symfony selectors (country flag GA)#978
Closed
mattgoud wants to merge 1 commit into
Closed
TE: migrate BOCountriesPage to Symfony selectors (country flag GA)#978mattgoud wants to merge 1 commit into
mattgoud wants to merge 1 commit into
Conversation
The 'country' feature flag is promoted to stable/enabled (state=1) in PrestaShop.
The legacy controller is no longer used — update the page object to use the
Symfony grid selectors.
Key changes vs legacy:
- Grid: #form-country/#table-country → #country_grid_panel/#country_grid_table
- Filter: countryFilter_* → td[data-column-id="*"]
- Columns: nth-child() positions → .column-* CSS classes
- Sort: icon-caret-up/down → ps-sort + data-sort-direction
- Pagination: legacy .pagination.pull-right → pagination-block
- Bulk: legacy dropdown → #country_grid .js-bulk-actions-btn
- Status toggle: action-enabled/disabled → .ps-switch input:checked
- deleteCountriesByBulkActions: no bulk-delete in Symfony grid,
implement as individual row deletes
- Options form: PS_RESTRICT_DELIVERED_COUNTRIES_on/off →
country_options_block_restrict_country_to_delivery_1/0
- settingsUpdateMessage: legacy flash → 'Update successful'
- Export: module.exports → ES module named export {boCountriesPage, BOCountriesPage}
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Progi1984
requested changes
May 26, 2026
Member
Progi1984
left a comment
Progi1984
left a comment
There was a problem hiding this comment.
It's denied. We don't add any E2E Tests on pages behind disabled features flag.
Contributor
Author
|
Closing this PR as per review feedback from @Progi1984: we don't add E2E tests on pages behind a disabled feature flag. The country feature flag is still |
github-project-automation
Bot
moved this from Waiting for author
to Closed
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
countryfeature flag is promoted tostable/state=1in PrestaShop (see PrestaShop/PrestaShop#41548). The Symfony-migrated Countries page is now always active, making the legacy selectors inBOCountriesPageobsolete.Changes
Rewrites
src/versions/develop/pages/BO/international/locations/countries/index.tsfrom legacy to Symfony selectors:#form-country#country_grid_panel#table-country#country_grid_tabletr.filter [name='countryFilter_*']tr.column-filters td[data-column-id="*"]td:nth-child(n)).column-name,.column-zone_name, …)i.icon-caret-up/downsort buttonsspan.ps-sort+data-sort-directionattributes.pagination.pull-rightdiv.pagination-block#country_grid .js-bulk-actions-btn.action-enabled/disabled.ps-switch input:checkedmodule.exports = new BOCountriesPage()export {boCountriesPage, BOCountriesPage}Notable behavior change: The Symfony Countries grid has no bulk-delete action.
deleteCountriesByBulkActions()is kept in the API but implemented as sequential individual row deletes, so existing tests continue to work without changes.settingsUpdateMessageupdated from the legacy flash to the Symfony flash:'Update successful'.Merge order
BOCountriesPageto Symfony selectorscountryfeature flag to stable + migrate Playwright testsRelated