Fix CI#243
Merged
Merged
Conversation
- Update actions/checkout from v2 to v6 and actions/cache from v1/v2 to v4 - Split PHPStan job into two: PS 8.1/8.2 (PHP 7.4–8.1) and PS 9.1.x/develop (PHP 8.1–8.5) - Replace deprecated matrix entries ["8.0", "latest"] with current versions - Add phpstan-8.1.neon, phpstan-8.2.neon, phpstan-9.1.x.neon, phpstan-develop.neon - Ignore addJS/addCSS LegacyControllerContext errors introduced in PS 9.x Adapted from PrestaShop/ps_facetedsearch#1233
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Progi1984
reviewed
Jun 3, 2026
Progi1984
reviewed
Jun 3, 2026
Codencode
approved these changes
Jun 3, 2026
ps-jarvis
added
the
Waiting for QA
Contributor
Author
|
@PrestaShop/qa-functional No need for QA here ? |
jolelievre
approved these changes
Jun 4, 2026
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ps-module-extension.neon, suppress PS9-specific type errors (LegacyControllerContext,Request,CartRule), fixdisplay()return type incompatibility between PS8 (bool) and PS9 (void), and remove the obsolete Docker-basedphpstan.shscript.8.1.7 × {7.4,8.1},8.2.x × {7.4,8.1},9.1.x × {8.1,8.5},develop × {8.1,8.5}) complete without errors.Changes
.github/workflows/php.ymlactions/checkoutupgraded to v6phpstan-74(PS 8.x, PHP 7.4/8.1) andphpstan(PS 9.x+, PHP 8.1/8.5)['8.1.7', '8.2.x']and['9.1.x', 'develop']prepend-constants.phpviaPHPRC/auto_prepend_fileto pre-define constants before any bootstrapcontrollers/front/FrontAjaxGdpr.phpdisplay(): replacedreturn false/return truewith barereturn— PS9 declares this method asvoid; PS8boolincompatibility is suppressed in neon configstests/phpstan/phpstan.neonincludesofps-module-extension.neon(the action already adds it as base config, causing a double-include error in PHPStan 2.x)tests/phpstan.sh(deleted) — obsolete Docker-based local PHPStan runner, replaced by the GitHub Actions workflow