Skip to content

Hide profile Security tab and Deactivate account for SSO (VITE_AUTH_TYPE=SSO)#40

Merged
UsamaSadiq merged 2 commits into
foss-sandboxfrom
jawad/hide-security-update-settings
May 22, 2026
Merged

Hide profile Security tab and Deactivate account for SSO (VITE_AUTH_TYPE=SSO)#40
UsamaSadiq merged 2 commits into
foss-sandboxfrom
jawad/hide-security-update-settings

Conversation

@jawad-khan
Copy link
Copy Markdown

Summary

  • Hide the Security tab in profile settings when the web app is built with VITE_AUTH_TYPE=SSO.
  • Hide the Deactivate account section on the Profile tab under the same condition.
  • Add a shared isSsoAuth() helper (apps/web/helpers/auth-config.helper.ts) aligned with existing SSO onboarding behavior.
  • Redirect /settings/profile/security to /settings/profile/general for SSO builds, and fall back to the Profile tab in the profile settings modal if Security was requested.

Motivation

SSO deployments manage authentication and account lifecycle outside Plane. Local password changes and self-service account deactivation are not applicable and should not be exposed in the UI.

Configuration

Set at build time (baked into the web bundle):

VITE_AUTH_TYPE=SSO

@jawad-khan
Copy link
Copy Markdown
Author

@copilot Please review.

…ed SMB_NAME type

Agent-Logs-Url: https://github.com/Pressingly/plane/sessions/35f3c0a2-8cd0-497a-a94b-9fd4c0d8e2dd

Co-authored-by: jawad-khan <5320368+jawad-khan@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI commented May 20, 2026

@copilot Please review.

Reviewed the changes. Everything looks functionally correct — the SSO redirects, sidebar hiding, and deactivate account suppression all work as intended. I made two cleanup improvements in commit e8ece4d:

  1. Removed duplicate isSsoAuth inline implementations in core/components/onboarding/profile-setup.tsx and core/components/onboarding/steps/profile/root.tsx — both files were still computing the check inline rather than using the new shared helper. They now import and call isSsoAuth() from helpers/auth-config.helper.ts.

  2. Removed unused SMB_NAME from vite-process-env.d.ts — it was declared as a required string but not referenced anywhere in the codebase, which could cause confusion about which env vars are available. Simplified to just Record<string, string | undefined>.

@jawad-khan jawad-khan changed the base branch from foss-main to foss-sandbox May 21, 2026 12:09
@UsamaSadiq UsamaSadiq merged commit 0d69487 into foss-sandbox May 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants