Skip to content

revert: retire pnpm@10.30.2 pin (PRs #22 + #28) — fixed upstream in v1.3.1 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hunzlahmalik merged 2 commits into from
May 20, 2026
Merged

revert: retire pnpm@10.30.2 pin (PRs #22 + #28) — fixed upstream in v1.3.1 #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11826f7
Revert "Merge pull request #22 from Pressingly/fix/corepack-pin-pnpm-…
hunzlahmalik May 20, 2026
0e816ac
Revert "fix: pin pnpm@10.30.2 in admin, live, space Dockerfiles (#28)"
hunzlahmalik May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions apps/admin/Dockerfile.admin
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN corepack enable pnpm

FROM base AS builder

RUN corepack prepare pnpm@10.30.2 --activate && pnpm add -g turbo@2.9.4
RUN pnpm add -g turbo@2.9.4

COPY . .

Expand Down Expand Up @@ -66,8 +66,6 @@ COPY --from=builder /app/out/pnpm-lock.yaml ./pnpm-lock.yaml
COPY --from=builder /app/out/full/ .
COPY turbo.json turbo.json

RUN corepack prepare pnpm@10.30.2 --activate

# Fetch dependencies to cache store, then install offline with dev deps
RUN --mount=type=cache,id=pnpm-store,target=/pnpm/store pnpm fetch --store-dir=/pnpm/store
RUN --mount=type=cache,id=pnpm-store,target=/pnpm/store CI=true pnpm install --offline --frozen-lockfile --store-dir=/pnpm/store --prod=false
Expand Down
4 changes: 2 additions & 2 deletions apps/live/Dockerfile.live
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ RUN apk add --no-cache libc6-compat
# Set working directory
WORKDIR /app
ARG TURBO_VERSION=2.9.4
RUN corepack prepare pnpm@10.30.2 --activate && pnpm add -g turbo@${TURBO_VERSION}
RUN corepack enable pnpm && pnpm add -g turbo@${TURBO_VERSION}
COPY . .
RUN turbo prune --scope=live --docker

Expand All @@ -33,7 +33,7 @@ WORKDIR /app
COPY .gitignore .gitignore
COPY --from=builder /app/out/json/ .
COPY --from=builder /app/out/pnpm-lock.yaml ./pnpm-lock.yaml
RUN corepack prepare pnpm@10.30.2 --activate
RUN corepack enable pnpm

# Copy full directory structure before fetch to ensure all package.json files are available
COPY --from=builder /app/out/full/ .
Expand Down
4 changes: 1 addition & 3 deletions apps/space/Dockerfile.space
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN corepack enable pnpm

FROM base AS builder

RUN corepack prepare pnpm@10.30.2 --activate && pnpm add -g turbo@2.9.4
RUN pnpm add -g turbo@2.9.4

COPY . .

Expand Down Expand Up @@ -67,8 +67,6 @@ COPY --from=builder /app/out/pnpm-lock.yaml ./pnpm-lock.yaml
COPY --from=builder /app/out/full/ .
COPY turbo.json turbo.json

RUN corepack prepare pnpm@10.30.2 --activate

# Fetch dependencies to cache store, then install offline with dev deps
RUN --mount=type=cache,id=pnpm-store,target=/pnpm/store pnpm fetch --store-dir=/pnpm/store
RUN --mount=type=cache,id=pnpm-store,target=/pnpm/store CI=true pnpm install --offline --frozen-lockfile --store-dir=/pnpm/store --prod=false
Expand Down
2 changes: 1 addition & 1 deletion apps/web/Dockerfile.web
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN apk add --no-cache libc6-compat
WORKDIR /app

ARG TURBO_VERSION=2.9.4
RUN corepack prepare pnpm@10.30.2 --activate && pnpm add -g turbo@${TURBO_VERSION}
RUN corepack enable pnpm && pnpm add -g turbo@${TURBO_VERSION}
COPY . .

RUN turbo prune --scope=web --docker
Expand Down