Skip to content

fix: fixed logout url issue #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jawad-khan wants to merge 2 commits into
base: foss-main
Choose a base branch
from
+3 −3
Open

fix: fixed logout url issue #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ec94fd
fix: fixed logout url issue
jawad-khan May 1, 2026
e4a266c
fix(logout): derive portal prefix from hostname instead of SMB_NAME env
awais786 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions surfsense_web/lib/auth-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,9 @@ export async function logout(): Promise<boolean> {
clearAllTokens();

if (typeof window !== "undefined") {
// Rewrite "foss-<app>.<domain>" → "foss.<domain>" so we land on the portal
// (outside ForwardAuth) instead of SurfSense's own root, which would silently re-auth.
const portalHost = window.location.hostname.replace(/^[^.]*\./, "moneta.");
// Rewrite "<prefix>-<app>.<domain>" → "<prefix>.<domain>" so we land on the
// portal (outside ForwardAuth) instead of SurfSense's own root, which would silently re-auth.
const portalHost = window.location.hostname.replace(/^([^-]+)-[^.]+\.(.+)/, "$1.$2");
window.location.href = `${window.location.protocol}//${portalHost}`;
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect uses window.location.hostname (no port) and builds protocol//host, which drops any non-default port the app is running on. This can break setups where SurfSense is accessed via an explicit port (e.g. localhost:3000 / mapped Docker ports). Consider preserving window.location.port when present (or using window.location.host and rewriting just the hostname portion).

Suggested change
window.location.href = `${window.location.protocol}//${portalHost}`;
const portSuffix = window.location.port ? `:${window.location.port}` : "";
window.location.href = `${window.location.protocol}//${portalHost}${portSuffix}`;

Copilot uses AI. Check for mistakes.
return true;
}
Expand Down
Loading