docs: reconcile MVP.md checklist with the implemented MVP#145
Merged
Conversation
Every item in the MVP.md checklist was left unchecked despite the endpoints
and DTOs being implemented and tested, so the document read as "nothing done".
Checked every endpoint/DTO verified present in the controllers/dto package
(mappings confirmed in EnvironmentController, GridController, LocationController,
EntityController, DebugController; DTO classes confirmed under dto/). Left a
single item unchecked: POST /api/v1/entities, which is currently implemented as
POST /api/v1/entities/{name} (path variable) rather than the documented
request-body form — annotated with a pointer to #135, which tracks that
alignment. Added a short status note referencing the same.
Closes #141
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every item in
docs/MVP.md's checklist was unchecked (- [ ]) even though the endpoints and DTOs are implemented and tested, so the document misrepresented MVP status as "nothing done". This reconciles the checklist with the actual implementation.src/main/java/preponderous/viron/dto/(EnvironmentDto,CreateEnvironmentRequest,UpdateEnvironmentNameRequest,GridDto,LocationDto,EntityDto).POST /api/v1/entities: implemented asPOST /api/v1/entities/{name}(path variable,EntityController:67), not the request-body form the checklist documents. Annotated inline with a pointer to Align entity write endpoints with request bodies + add entity resource to OpenAPI spec #135, which tracks that alignment.Verification
Each checked box was confirmed against the controller
@*Mappingannotations and thedto/directory — not from memory. The single unchecked item was confirmed to still diverge (path variable vs. body).Test plan
Closes #141
🤖 Generated with Claude Code