remove migrations to be run manually#78
Closed
JamesMcMinn wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
This PR has gone about as well as Scotland's world cup did. Closing for now while I fix 🫠 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies #75
This remove the automatic migration that formed part of this fix.
The migration affects quite a few rows, and causes a number of issues during deployment which resulted in downtime (boo).
Rather than rely on the automatic migration, I'm extracting the migration and will run it manually in small steps. We do however need to keep the code changes which prevent future sentences from getting assigned invalid "2" letter ISO codes.