Draft version - #3
Open
Pr0meTheuSS wants to merge 3 commits into
Open
Conversation
Collaborator
finish your work with graceful shutdown. Only HTTP 1.0 required. |
k-stolyarov
requested changes
Dec 20, 2023
| char buffer[BUFFER_SIZE]; | ||
| ssize_t bytes_received, bytes_sent; | ||
|
|
||
| bytes_received = recv(client_socket, buffer, sizeof(buffer), 0); |
Collaborator
There was a problem hiding this comment.
Please handle requests that longer than BUFFER_SIZE-1
| *client_socket_ptr = client_socket; | ||
|
|
||
| // Create a new thread to handle the request | ||
| if (pthread_create(&tid, NULL, handle_request, (void *)client_socket_ptr) != 0) { |
Collaborator
There was a problem hiding this comment.
Please check what is the maximum amount of concurrently handled connections and explain what limiting factor you faced.
Owner
Author
There was a problem hiding this comment.
This is due to the fact that the system has a limit on the number of open file descriptors, and open sockets use this resource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a draft version of the proxy. In the following episodes:
QUESTION:
should this proxy work with https too?