fix: export ConvertTo-JsonManifest as a public function#455
Merged
Conversation
Move ConvertTo-JsonManifest from Private/ to Public/ so the build includes it in FunctionsToExport. Also correct the README examples which referenced non-existent -InputObject and -OutputPath parameters. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Test Results 3 files 213 suites 42s ⏱️ Results for commit a20defe. ♻️ This comment has been updated with latest results. |
…sonManifest Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… double-binding bug Tests cover output format, metadata mapping, parameters (text, choice, multichoice, condition), and content actions (file, templateFile, message, requireModule). Writing the tests exposed two bugs in the function: - $jsonObject was passed both via pipeline and via -InputObject in the splatted hashtable, causing ParameterBindingException on every call - The -Compress flag logic was inverted (set false when unset, nothing when set) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #453
Summary
ConvertTo-JsonManifest.ps1fromPlaster/Private/toPlaster/Public/so the build system includes it in the compiled module's exported functions-InputObjectand-OutputPathparameters (actual parameter is-XmlManifest; output is a string to pipe toSet-Content)Test plan
Import-Module PlasterthenGet-Command ConvertTo-JsonManifestshould resolveTest-PlasterManifest -Path .\plasterManifest.xml | ConvertTo-JsonManifestshould return valid JSON🤖 Generated with Claude Code