Skip to content

CHORES: add skeleton VCI draft PR#46

Draft
D3Portillo wants to merge 19 commits into
mainfrom
feature/vci-playground
Draft

CHORES: add skeleton VCI draft PR#46
D3Portillo wants to merge 19 commits into
mainfrom
feature/vci-playground

Conversation

@D3Portillo

@D3Portillo D3Portillo commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

Vault Creator Interface [WIP]

This pr will hold the development of VCI to playground with the Popcorn Team. Current state uses jotai to keep localStorate save content, which would benefit to keep the data model for the app consistent/shared. For UI elements headless-ui is used (apart from our core stack: rainbowkit, ethers, nextjs and tailwind).

Suggestions are open.

Reference

image

The following PR will modify the following:

Comment thread packages/vci/.gitignore
.pnpm-debug.log*

# local env files
.env*.local

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't .env also be ignored?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think thats ignored by default no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, from next-create it's not gitignored. Good catch. Adding.env!

Comment thread packages/vci/pages/api/hello.ts Outdated
@@ -0,0 +1,13 @@
// Next.js API route support: https://nextjs.org/docs/api-routes/introduction
import type { NextApiRequest, NextApiResponse } from 'next'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing in next commits. Not used.

@vercel

vercel Bot commented Mar 20, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
monorepo-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 23, 2023 at 2:38PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VCI - Fee Configuration VCI - Protocol Selection VCI - Asset Selection

3 participants