Feat/compounding strategy#45
Draft
RedVeil wants to merge 22 commits into
Draft
Conversation
RedVeil
commented
Mar 2, 2023
RedVeil
commented
Mar 2, 2023
RedVeil
commented
Mar 2, 2023
| } | ||
|
|
||
| // Return available rewards for all rewardTokens. | ||
| function rewardsAvailable() public override returns (uint256[] memory) { |
Contributor
Author
There was a problem hiding this comment.
What is this exactly needed for? I think we only need to call IAdapter(address(this)).rewardTokens and than claim after
maybe im missing smth here
Contributor
There was a problem hiding this comment.
IAdapter(address(this)).rewardTokens returns the addresses of the tokens while this function returns the amounts of the tokens available for harvest
function rewardsAvailable() public virtual returns (uint256[] memory) {}
It's meant for a check to make sure that there are rewards to harvest before calling the harvest function.
It's an extra check, but perhaps unnecessary.
RedVeil
commented
Mar 2, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.