Skip to content

blocksec improvements #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RedVeil wants to merge 18 commits into
base: master
Choose a base branch
from
Open

blocksec improvements #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
298cf48
blocksec improvements
RedVeil Mar 28, 2023
5b67d71
fixed issue 4 and 12
RedVeil Mar 31, 2023
52588f2
implemented recommendation-2
RedVeil Apr 5, 2023
553fbb2
implemented recommendation-4
RedVeil Apr 5, 2023
d9eeddb
deleted managementFee var from takeFees
RedVeil Apr 5, 2023
fd478b5
adjusted addRewardToken for 0 rewardSpeed
RedVeil Apr 11, 2023
d4428ef
round assets affected by withdrawalFee down (beefy)
RedVeil Apr 11, 2023
e0a3275
only charge manangementFees from first deposit/mint
RedVeil Apr 11, 2023
0cc913d
qa - updated incorrect comments
RedVeil Apr 11, 2023
41fa715
moved UnderlyingError into AdminProxy
RedVeil Apr 11, 2023
8b1e5d1
added maxLoss to yearnAdapter
RedVeil Apr 11, 2023
5f1b3e9
wip - added MasterChefV2
RedVeil Apr 11, 2023
0f94ef1
MasterChefV2 adapter working
RedVeil Apr 12, 2023
1819f2b
fixed compoundV2 rewardsCheck
RedVeil Apr 12, 2023
afaa6ac
renamed missmatch to mismatch
RedVeil Apr 12, 2023
c34007f
renamed missmatch to mismatch 2
RedVeil Apr 12, 2023
061df2d
wip - wrap claims in try-catch
RedVeil Apr 12, 2023
89c38c3
claim now returns success
RedVeil Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/solmate
Open in desktop
Submodule solmate updated 3 files
+118 −39 .gas-snapshot
+416 −0 src/test/SafeCastLib.t.sol
+120 −0 src/utils/SafeCastLib.sol
48 changes: 25 additions & 23 deletions src/interfaces/vault/IAdapter.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,43 +3,45 @@

pragma solidity ^0.8.15;

import { IOwned } from "../IOwned.sol";
import { IERC4626Upgradeable as IERC4626 } from "openzeppelin-contracts-upgradeable/interfaces/IERC4626Upgradeable.sol";
import { IPermit } from "../IPermit.sol";
import { IPausable } from "../IPausable.sol";
import {IOwned} from "../IOwned.sol";
import {IERC4626Upgradeable as IERC4626} from "openzeppelin-contracts-upgradeable/interfaces/IERC4626Upgradeable.sol";
import {IPermit} from "../IPermit.sol";
import {IPausable} from "../IPausable.sol";

interface IAdapter is IERC4626, IOwned, IPermit, IPausable {
function strategy() external view returns (address);
function strategy() external view returns (address);

function strategyConfig() external view returns (bytes memory);
function strategyConfig() external view returns (bytes memory);

function strategyDeposit(uint256 assets, uint256 shares) external;
function strategyDeposit(uint256 assets, uint256 shares) external;

function strategyWithdraw(uint256 assets, uint256 shares) external;
function strategyWithdraw(uint256 assets, uint256 shares) external;

function supportsInterface(bytes4 interfaceId) external view returns (bool);
function supportsInterface(bytes4 interfaceId) external view returns (bool);

function setPerformanceFee(uint256 fee) external;
function setPerformanceFee(uint256 fee) external;

function performanceFee() external view returns (uint256);
function performanceFee() external view returns (uint256);

function highWaterMark() external view returns (uint256);
function highWaterMark() external view returns (uint256);

function accruedPerformanceFee() external view returns (uint256);
function accruedPerformanceFee() external view returns (uint256);

function harvest() external;
function harvest() external;

function harvestCooldown() external view returns (uint256);
function lastHarvest() external view returns (uint256);

function setHarvestCooldown(uint256 harvestCooldown) external;
function harvestCooldown() external view returns (uint256);

function initialize(
bytes memory adapterBaseData,
address externalRegistry,
bytes memory adapterData
) external;
function setHarvestCooldown(uint256 harvestCooldown) external;

function decimals() external view returns (uint8);
function initialize(
bytes memory adapterBaseData,
address externalRegistry,
bytes memory adapterData
) external;

function decimalOffset() external view returns (uint8);
function decimals() external view returns (uint8);

function decimalOffset() external view returns (uint8);
}
4 changes: 2 additions & 2 deletions src/interfaces/vault/IWithRewards.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
pragma solidity ^0.8.15;

interface IWithRewards {
function claim() external;
function claim() external returns (bool);

function rewardTokens() external view returns (address[] memory);
function rewardTokens() external view returns (address[] memory);
}
Loading