Add Sequence Validation Warnings to jsonwriter.py#132
Open
rbaldwin-bugseq wants to merge 8 commits into
Open
Conversation
- Add logic to check ambiguous dictionary for unsequenced positions - Simplify code by using mutation[2] directly instead of consensus variable - This ensures all ambiguous positions at DRPs are reported, not just X mutations
Keep only the DRP ambiguity warnings feature.
Only check mutation list for X at DRPs, not both mutation list and ambiguous dict. This eliminates duplicate warnings like '10' and 'K10' for the same position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was a response to this issue:
Handling of X amino acids/masked sequences · Issue #110 · PoonLab/sierra-local
Here's the original input:
K03455_masked.fna.gz
Here's the results of this branch based on that input:
results.json
I tried to match sierra behavior as much as possible
Enhanced Sequence Validation Warnings
File: sierra-local/sierralocal/jsonwriter.py