fix error C2589#2
Open
shimenga wants to merge 2 commits into
Open
Conversation
- backdrop.cpp / glass.cpp: expand compact single-line D3D11 state-creation blocks (buffer/sampler/blend/rasterizer/depth-stencil) into multi-line, properly indented braces for readability. - surfaces.cpp / glass.cpp: add `#undef max` / `#undef min` to prevent the Windows macros from interfering with std::numeric_limits and template uses. - surfaces.cpp: expand compact loops and inline branches in RoundedGrad, ImgOrGrad and SurfaceLaunchpad into clearer multi-line form. No runtime behavior changes; whitespace/brace reformatting plus the min/max undef guard.
Author
|
After downloading, the code wouldn't compile, so I made modifications to fix error C2589. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#undef max/#undef minto prevent the Windows macros from interfering with std::numeric_limits and template uses.No runtime behavior changes; whitespace/brace reformatting plus the min/max undef guard.
Summary
Applied Visual Studio code formatting to reorganize the affected files, expanding compact blocks into multi-line structures for improved readability. Also added
#undef max/#undef minpreprocessor directives to fix MSVC error C2589 caused by Windows macros conflicting withstd::numeric_limits.Testing
Full project build completed successfully with no compilation errors.