Skip to content

Db v4 move graph folder#2624

Draft
arienandalibi wants to merge 3 commits into
db_v4from
db_v4_move_graph_folder
Draft

Db v4 move graph folder#2624
arienandalibi wants to merge 3 commits into
db_v4from
db_v4_move_graph_folder

Conversation

@arienandalibi
Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

Move graph_folder.rs constants (directory and file names regarding exported graphs) out of the raphtory crate and into raphtory-api.

Why are the changes needed?

Following previous changes, we needed access to GRAPH_META_PATH in pometry-storage, where we can't import from raphtory.

Does this PR introduce any user-facing change? If yes is this documented?

No

How was this patch tested?

Tests still pass

Are there any further changes required?

No

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 9d1ddfc Previous: 9823ef7 Ratio
lotr_graph/num_edges 4 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 4 ns/iter (± 0) 1 ns/iter (± 0) 4
lotr_graph/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph/iterate_exploded_edges 624833 ns/iter (± 1287) 285473 ns/iter (± 2920) 2.19
lotr_graph/graph_latest 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 7991923 ns/iter (± 34100) 1564816 ns/iter (± 35303) 5.11
lotr_graph_window_100/num_nodes 14 ns/iter (± 0) 5 ns/iter (± 0) 2.80
lotr_graph_window_100/iterate_exploded_edges 834715 ns/iter (± 4624) 325242 ns/iter (± 847) 2.57
lotr_graph_window_100_materialise/materialize 8395342 ns/iter (± 14670) 1669150 ns/iter (± 10700) 5.03
lotr_graph_window_10/has_node_existing 154 ns/iter (± 9) 62 ns/iter (± 11) 2.48
lotr_graph_window_10/iterate nodes 35248 ns/iter (± 58) 11339 ns/iter (± 40) 3.11
lotr_graph_window_10/iterate edges 103120 ns/iter (± 1126) 48684 ns/iter (± 211) 2.12
lotr_graph_window_10/iterate_exploded_edges 409296 ns/iter (± 1676) 155788 ns/iter (± 1001) 2.63
lotr_graph_window_10_materialise/materialize 3652806 ns/iter (± 13516) 971980 ns/iter (± 4278) 3.76
lotr_graph_subgraph_10pc/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_subgraph_10pc_materialise/materialize 1661428 ns/iter (± 7343) 334634 ns/iter (± 1287) 4.96
lotr_graph_subgraph_10pc_windowed/has_node_existing 161 ns/iter (± 10) 62 ns/iter (± 14) 2.60
lotr_graph_subgraph_10pc_windowed/iterate nodes 5812 ns/iter (± 126) 1365 ns/iter (± 3) 4.26
lotr_graph_subgraph_10pc_windowed_materialise/materialize 1034294 ns/iter (± 8040) 230399 ns/iter (± 2617) 4.49
lotr_graph_window_50_layered/num_edges 78463 ns/iter (± 2256) 38714 ns/iter (± 1017) 2.03
lotr_graph_window_50_layered/num_edges_temporal 160697 ns/iter (± 2723) 70121 ns/iter (± 7586) 2.29
lotr_graph_window_50_layered/has_node_existing 452 ns/iter (± 23) 129 ns/iter (± 12) 3.50
lotr_graph_window_50_layered/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_window_50_layered/iterate nodes 79780 ns/iter (± 370) 19308 ns/iter (± 47) 4.13
lotr_graph_window_50_layered/iterate edges 206947 ns/iter (± 400) 83616 ns/iter (± 1318) 2.47
lotr_graph_window_50_layered/graph_latest 82097 ns/iter (± 1361) 36649 ns/iter (± 916) 2.24
lotr_graph_window_50_layered_materialise/materialize 33991305 ns/iter (± 109012) 3488825 ns/iter (± 24948) 9.74
lotr_graph_persistent_window_50_layered/num_edges_temporal 676856 ns/iter (± 5172) 192686 ns/iter (± 1569) 3.51
lotr_graph_persistent_window_50_layered/has_node_existing 496 ns/iter (± 332) 174 ns/iter (± 83) 2.85
lotr_graph_persistent_window_50_layered/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_persistent_window_50_layered/iterate nodes 106993 ns/iter (± 374) 35886 ns/iter (± 191) 2.98
lotr_graph_persistent_window_50_layered/iterate edges 198801 ns/iter (± 3414) 84161 ns/iter (± 596) 2.36
lotr_graph_persistent_window_50_layered/iterate_exploded_edges 4977083 ns/iter (± 12178) 1659940 ns/iter (± 19402) 3.00
lotr_graph_persistent_window_50_layered/graph_latest 120007 ns/iter (± 1649) 57549 ns/iter (± 4809) 2.09
lotr_graph_persistent_window_50_layered_materialise/materialize 61153709 ns/iter (± 128487) 5298035 ns/iter (± 147912) 11.54

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant