Update row_size in WriteLockedPropMapper#2621
Merged
Merged
Conversation
ljeub-pometry
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: ed59887 | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph/iterate_exploded_edges |
627921 ns/iter (± 1082) |
285473 ns/iter (± 2920) |
2.20 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
8012720 ns/iter (± 18679) |
1564816 ns/iter (± 35303) |
5.12 |
lotr_graph_window_100/num_nodes |
14 ns/iter (± 0) |
5 ns/iter (± 0) |
2.80 |
lotr_graph_window_100/iterate_exploded_edges |
860994 ns/iter (± 1962) |
325242 ns/iter (± 847) |
2.65 |
lotr_graph_window_100_materialise/materialize |
8428259 ns/iter (± 19234) |
1669150 ns/iter (± 10700) |
5.05 |
lotr_graph_window_10/has_node_existing |
157 ns/iter (± 11) |
62 ns/iter (± 11) |
2.53 |
lotr_graph_window_10/iterate nodes |
34765 ns/iter (± 612) |
11339 ns/iter (± 40) |
3.07 |
lotr_graph_window_10/iterate edges |
100825 ns/iter (± 217) |
48684 ns/iter (± 211) |
2.07 |
lotr_graph_window_10/iterate_exploded_edges |
411507 ns/iter (± 1013) |
155788 ns/iter (± 1001) |
2.64 |
lotr_graph_window_10_materialise/materialize |
3645104 ns/iter (± 7113) |
971980 ns/iter (± 4278) |
3.75 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
1666475 ns/iter (± 9679) |
334634 ns/iter (± 1287) |
4.98 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
162 ns/iter (± 12) |
62 ns/iter (± 14) |
2.61 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
5756 ns/iter (± 91) |
1365 ns/iter (± 3) |
4.22 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1026641 ns/iter (± 9250) |
230399 ns/iter (± 2617) |
4.46 |
lotr_graph_window_50_layered/num_edges |
80650 ns/iter (± 2153) |
38714 ns/iter (± 1017) |
2.08 |
lotr_graph_window_50_layered/num_edges_temporal |
164183 ns/iter (± 3256) |
70121 ns/iter (± 7586) |
2.34 |
lotr_graph_window_50_layered/num_nodes |
43695 ns/iter (± 2030) |
21435 ns/iter (± 536) |
2.04 |
lotr_graph_window_50_layered/has_node_existing |
445 ns/iter (± 23) |
129 ns/iter (± 12) |
3.45 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/iterate nodes |
80258 ns/iter (± 528) |
19308 ns/iter (± 47) |
4.16 |
lotr_graph_window_50_layered/iterate edges |
204468 ns/iter (± 407) |
83616 ns/iter (± 1318) |
2.45 |
lotr_graph_window_50_layered/max_neighbour_degree |
774412 ns/iter (± 2008) |
386651 ns/iter (± 3853) |
2.00 |
lotr_graph_window_50_layered/graph_latest |
81969 ns/iter (± 2318) |
36649 ns/iter (± 916) |
2.24 |
lotr_graph_window_50_layered_materialise/materialize |
33800726 ns/iter (± 42048) |
3488825 ns/iter (± 24948) |
9.69 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
680766 ns/iter (± 6651) |
192686 ns/iter (± 1569) |
3.53 |
lotr_graph_persistent_window_50_layered/has_node_existing |
499 ns/iter (± 355) |
174 ns/iter (± 83) |
2.87 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/iterate nodes |
108706 ns/iter (± 2018) |
35886 ns/iter (± 191) |
3.03 |
lotr_graph_persistent_window_50_layered/iterate edges |
190416 ns/iter (± 1265) |
84161 ns/iter (± 596) |
2.26 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
4831614 ns/iter (± 10971) |
1659940 ns/iter (± 19402) |
2.91 |
lotr_graph_persistent_window_50_layered/graph_latest |
120139 ns/iter (± 5448) |
57549 ns/iter (± 4809) |
2.09 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
60665192 ns/iter (± 123015) |
5298035 ns/iter (± 147912) |
11.45 |
lotr_graph/proto_encode |
9648846 ns/iter (± 87779) |
1157897 ns/iter (± 73709) |
8.33 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Keep track of
row_sizeinWriteLockedPropMapperand update it whenever a new property is added.Why are the changes needed?
Non-bulk loading write methods such as
add_nodeandadd_edgeuse theWriteLockedPropMapperto update the property schema. Without updating therow_sizein tandem, we get poor memory estimates for flushing segments to disk.Does this PR introduce any user-facing change? If yes is this documented?
No.
How was this patch tested?
Added unit tests for
WriteLockedPropMapper.Are there any further changes required?
No.