fix: omit user stream market filter for all markets#131
Open
cesarenaldi wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marketsfilter when subscribing to all marketsmarkets: [...]Verification
pnpm lintpnpm typecheckpnpm test:clientNotes
Note
Medium Risk
Changes live websocket subscription wire format for a common
{ topic: 'user' }path, which can affect real-time order/trade delivery; behavior is intentional and test-covered but touches trading-adjacent infrastructure.Overview
Broad user websocket subscriptions no longer send a
marketsfield on the initial subscribe frame whenincludeAllMarketsis true (buildUserSubscribeMessageinprotocol.ts). Narrow subscriptions still includemarkets: [...]. This aligns with the Python SDK fix so all-market user streams can receive trade events (and related updates) that were previously filtered incorrectly.Bindings: e6-scaled bigint string parsing is centralized as
E6BigIntStringToDecimalStringSchemainshared.ts(RFQ schemas now import it). Order response empty-string amount normalization is renamed toOrderResponseAmountSchemawith no behavior change.Tests: Unit coverage for the all-markets subscribe frame; user subscription integration tests move into
subscriptions.test.ts, including a metered test that asserts a trade event after a market order. Standaloneuser-subscriptions.test.tsis removed.Reviewed by Cursor Bugbot for commit 11818ef. Bugbot is set up for automated code reviews on this repo. Configure here.