First fix to the 'Cannot open Rotom phone menu after multiple retries...' error#1259
Draft
Boombaastical wants to merge 1 commit into
Draft
First fix to the 'Cannot open Rotom phone menu after multiple retries...' error#1259Boombaastical wants to merge 1 commit into
Boombaastical wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it was currently stuck on a reproducible loop with this error, I could just test it multiple times. I simply added a EggBlackDialogBoxDetector, as sneakily enough, the BlackDialogBoxDetector was just not aligned with the dialog box when the eggs hatch (pictures attached, they're slightly different).
Tested it for some time now, it got out of the loop, I will leave it as a draft for now and then update it to a proper PR if it continues to loop without that error. The other error of having an egg left in the party I believe isn't that big of a deal as every time it happens, the reload loop fixes it.

