Address backend config review feedback#77
Merged
Conversation
Fix correctness issues found in review of the composable backend configs. - Discord: request the privileged `message_content` intent in the preset so guild command text is delivered; document the Developer Portal requirement. - Symphony: complete the preset with `host`, `bot_username`, and certificate auth via a combined `.pem` (`bot_certificate_path`), which the bare key-content preset could not start; update docs and examples. - Commands: fix `to_chatom_user()` on already-`chatom.User` targets in the built-in echo command and in the Writing-Commands guide; pass targets straight to `mention_users`. Update echo tests to use real users instead of mocks that hid the bug. - Docs: keep the built-in commands in the custom-command registration example and note that command modules must be importable on PYTHONPATH. - Tests: add gateway/backend composition coverage over every pre-canned gateway plus ad-hoc `+backend=[...]` selection. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 65.49% 66.41% +0.92%
==========================================
Files 29 30 +1
Lines 1672 1694 +22
Branches 170 171 +1
==========================================
+ Hits 1095 1125 +30
+ Misses 545 537 -8
Partials 32 32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix correctness issues found in review of the composable backend configs.
message_contentintent in the preset so guild command text is delivered; document the Developer Portal requirement.host,bot_username, and certificate auth via a combined.pem(bot_certificate_path), which the bare key-content preset could not start; update docs and examples.to_chatom_user()on already-chatom.Usertargets in the built-in echo command and in the Writing-Commands guide; pass targets straight tomention_users. Update echo tests to use real users instead of mocks that hid the bug.+backend=[...]selection.