[codex] Fix package module entry#45
Open
luuhongyii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the package ESM entry in
package.json.The published package currently points
moduleatdist/index.esm.js, but the package/build output containsdist/index.mjsinstead. ESM consumers and tooling that prefer themodulefield can therefore resolve a file that is not present in the package.Change
modulefromdist/index.esm.jstodist/index.mjs.Validation
pnpm install --frozen-lockfile --ignore-scriptspnpm buildnpm pack --dry-run --jsonnode -e "const p=require('./package.json'); console.log(JSON.stringify({main:p.main,module:p.module}))"git diff --checkI also ran
pnpm test. It completed with 9/10 suites passing, 27/30 tests passing, and 33/36 snapshots passing. The remaining failures are three CSS snapshot diffs insrc/test/global-style/global-style.test.tsshowing output formatting/trailing-newline differences; I did not update snapshots because this PR only changes the package manifest entry.