Fix keymapConfig.getter recursion#220
Closed
Max-Sum wants to merge 1 commit into
Closed
Conversation
Max-Sum
force-pushed
the
keymapping-config
branch
from
55f2d09 to
b49c98e
Compare
Author
|
This is not the root cause. See PlayCover/PlayCover#2126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS 26.4.1, the following error occurs, leading to a crash on App launch.
dyld → PlayTools initialize → PlayCover.launch()
→ PlayInput.initialize() → ControlMode.initialize()
→ ActionDispatcher.build() → Keymapping.init()
→ Keymapping.loadKeymapData() → keymapConfig.getter
→ PropertyListEncoder.encode() → keymapConfig.getter
→ keymapConfig.getter → (Endless recursion)
PlayCover/PlayCover#2106
PlayCover/PlayCover#2109
This patch fixes it.