Implement research-based analog drum synthesis refinements#129
Implement research-based analog drum synthesis refinements#129Pitrat-wav wants to merge 1 commit into
Conversation
Refined the drum synthesis engine based on the 'Deep DSP Analysis' research: - Implemented 15-bit LFSR noise generation for authentic TR-909 textures. - Added 'diode damping' two-stage amplitude envelope for the TR-808 Kick. - Integrated randomized noise start offsets to eliminate the 'machine-gun' effect. - Calibrated pitch sweeps and filter parameters for 808/909 models. - Implemented state synchronization between the UI store and the internal audio engine. - Added early-exit optimizations for silent drum triggers. - Ensured Web Audio API safety with strictly positive exponential ramp targets. Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3d21133fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // x^15 + x^14 + 1 | ||
| const bit = ((state >> 14) ^ (state >> 13)) & 1; | ||
| state = ((state << 1) | bit) & 0x7FFF; | ||
| data[i] = (state / 0x7FFF) * 2 - 1; |
There was a problem hiding this comment.
When the 909 snare uses this buffer, each sample is derived from the entire shifted register state rather than the generated LFSR output bit, so consecutive samples remain strongly correlated as the register shifts instead of producing the intended pseudo-random bitstream. This makes the new “LFSR noise” behave more like a stepped/ramping waveform than TR-909-style noise; map the feedback/output bit (for example the LSB after the shift) to -1/1 instead of scaling state.
Useful? React with 👍 / 👎.
1 participant
This PR implements comprehensive refinements to the drum synthesis logic, strictly following the provided 'Программный синтез аналоговых ударных инструментов: Глубокий DSP-анализ и реализация на базе Web Audio API' research.
Key changes:
DrumUtils.tsfor TR-909 Snare.syncInternalParamstoDrumMachineand integrated it intoaudioStoreto ensure engine parameters are correctly initialized from the application state.velocity <= 0checks in all drum classes to skip node scheduling for silent steps.Math.max(0.001, ...)for all exponential ramps to prevent Web Audio API errors.PR created automatically by Jules for task 2903479066001877143 started by @Pitrat-wav