Upgrade Drum Synthesis to Authentic DSP Models#121
Conversation
- Implemented authentic 15-bit LFSR noise for TR-909 Snare. - Updated TR-808 Kick with two-stage envelopes for damping and 'tonk' articulation. - Refactored pitch drift to use cent-based logarithmic frequency deviation. - Implemented robust `activeVoices` tracking and disposal for metallic instruments. - Standardized volume keys (cow -> cowbell) across the application. - Added 'Randomize Techno' feature with haptic feedback. - Updated default Euclidean patterns to techno foundation. Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR upgrades the drum synthesis engine to strictly adhere to the provided DSP research.
Key changes:
generateLFSRNoise(15-bit) and updatedapplyPitchDriftto use musical cents.activeVoicestracking for Hi-Hat and Cowbell to ensure proper node disposal and prevent memory leaks.cowvolume keys tocowbelland added initial state synchronization in the audio store.PR created automatically by Jules for task 188708286604609330 started by @Pitrat-wav