Validate thread count in thpool_init() and return NULL for non-positi…#136
Open
Lee-shihao wants to merge 1 commit into
Open
Validate thread count in thpool_init() and return NULL for non-positi…#136Lee-shihao wants to merge 1 commit into
Lee-shihao wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a sanity check to thpool_init() to ensure that the number of threads passed during initialization is greater than zero. If a non-positive value (≤ 0) is provided, the function now logs an error and returns NULL.
Previously, passing num_threads <= 0 would silently proceed, potentially resulting in a thread pool with zero threads—causing jobs to never be executed and thpool_wait() to hang indefinitely.