fix(storage): reset size_written only after successful clear - #20
Open
kevetka wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
In both clear_database and clear_database_full methods of ChunkStorage, the size_written counter was being reset to 0 before calling the fallible database.clear(). If clear() returns an Err, the method propagates the error to the caller, but size_written has already been zeroed. This leaves the storage in an inconsistent state: the database still contains all data, yet the byte counter indicates that nothing has been written.
Fix:
Reordered the operations so that size_written is updated only after all fallible operations have succeeded:
With this fix, if clear() fails, the state remains consistent: the database is untouched and size_written still reflects the actual amount of stored data.