feat(storage): add target_dedup_ratio and full_dedup_size - #13
Merged
Conversation
Vlm326
reviewed
Jul 10, 2026
| } | ||
|
|
||
| fn full_dedup_size(&self) -> usize { | ||
| let size = self.database.iterator().fold(0, |acc, (_, container)| { |
Contributor
There was a problem hiding this comment.
можно удалить переменную и просто возвращать напрямую результат функции
| (self.size_written as f64) / (self.total_cdc_size() as f64) | ||
| } | ||
|
|
||
| fn full_dedup_size(&self) -> usize { |
Contributor
There was a problem hiding this comment.
мне кажется что стоит использоовать map + sum, такой подход будет более читаемым, тем более здесь нету какого то сохранения состояния, но это субъективно
Contributor
Author
There was a problem hiding this comment.
в соответствии с уже написанным кодом я принял решение использовать fold()
| } | ||
|
|
||
| fn target_dedup_size(&self) -> usize { | ||
| self.database.iterator().fold(0, |acc, (_, container)| { |
Contributor
There was a problem hiding this comment.
аналогично я бы изменил на map + sum
Vlm326
reviewed
Jul 10, 2026
| .sum(), | ||
| } | ||
| }) | ||
| } |
Contributor
There was a problem hiding this comment.
тут нету комментариев с докой, хотя остальные публичные методы у нас задокументированны
Vlm326
suggested changes
Jul 10, 2026
Vlm326
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.