fix: release dns_cache reference on timer rearm path#478
Open
PikuZheng wants to merge 3 commits into
Open
Conversation
Fork Sync
Fork Sync
|
[edns.ipk]这个edns是代表什么版本? |
Owner
Author
编译时附加参数 CFLAGS="-DFEATURE_CHECK_EDNS" |
感谢解释 |
|
最新的2026.v48.0.15 |
Owner
Author
编译失败了呗 |
Owner
Author
改好了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dns_cache_expired()holding adns_cachereference when the timeout callback returned UPDATE/RETRY anddns_timer_mod()was attempted but not accounted for, leading to transient retained references during concentrated expirations.Description
dns_cache_release()is always called on the UPDATE/RETRYoutpath insrc/dns_cache.cso a faileddns_timer_mod()does not omit releasing the held cache reference.mod_retvariable and simplify thedns_timer_mod()calls so the release is unconditional on the out path.Testing
make -j2and the build completed successfully.make -C src dns_cache.oand the compilation completed successfully.Codex Task