changed for MAJOR-3, issue 123#143
Merged
Merged
Conversation
PieterKas
reviewed
Jun 26, 2026
PieterKas
reviewed
Jun 26, 2026
PieterKas
requested changes
Jun 26, 2026
PieterKas
left a comment
PieterKas
left a comment
Owner
There was a problem hiding this comment.
Overall looks good. Let's seperate changing the document type from info to bcp until we had a discussion. Changing the type of the document seems like it is orthogonal to the other changes suggested.
Co-authored-by: PieterKas <90690777+PieterKas@users.noreply.github.com>
Collaborator
Author
|
Applied the changes |
PieterKas
reviewed
Jun 29, 2026
PieterKas
approved these changes
Jun 30, 2026
PieterKas
reviewed
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #123 Trying to attenuate the MUST and SHOULD by approaching it via BCP