Update League of Legends script

[ImperatorS79]

Description

Fix broken installation script

What works

Installation

What was not tested

Game itself

Test

• Operating system (and linux kernel version): ubuntu 19.04 5.0.0-25-generic
• Hardware (GPU/CPU): Intel core i3-7100

Ready for review

• Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
• json-align and eslint run according to the documentation.
• Codacy and travis checked.

[Zemogiter]

Tried EU West and East installers, still getting that dx9 error.

[ImperatorS79]

@Zemogiter Could you check the wine log and the content of your runtime because this is definitely weird.

[Zemogiter]

This is weird. I've applied the latest commit from this PR to my local repo and the installation went fine no more dx9 errors. I've noticed that it downloaded the runtime now (before the .Phoenicis/engines/wine/runtime folder was empty). Perhaps we need to add a force runtime download button in the options menu.

[ImperatorS79]

Did you try launching the game ?

[Zemogiter]

I can't because I forget password & username. Waiting for email.

[plata]

@ImperatorS79 can you fix the conflicts?

[Zemogiter]

There are still conflicting files.

[Zemogiter]

Codacy complains

[madoar]

I must confessed I forgot about the current status of this PR. Is the game in theory playable after applying this PR or are there still some issues with the game itself (like the anti-cheat protection making issues etc.)?

[ImperatorS79]

I guess the game should work. At least the game can install with this PR while before it could not.

[Kreyren]

I guess the game should work. At least the game can install with this PR while before it could not.

there are changes made in the wine so that's why is it working.. should work no issue on staging wine now

[plata]

Can anybody verify this such that we can merge the PR?

[Zemogiter]

After the setup file is downloaded I get this error:

[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - Executable LeagueClient.exe not found!
	at <js> create(Unnamed:174:4783-4834)
	at <js> _createShortcut(Unnamed:184:4986-5002)
	at <js> go(Unnamed:98:3725-3759)
	at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke(HostInteropReflect.java:678)
	at com.sun.proxy.$Proxy68.go(Unknown Source)
	at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7(ApplicationInformationPanelSkin.java:237)
	at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
	at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

[WARNING] 
org.graalvm.polyglot.PolyglotException: Executable LeagueClient.exe not found!
    at <js>.create (Unnamed:174)
    at <js>._createShortcut (Unnamed:184)
    at <js>.go (Unnamed:98)
    at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke (HostInteropReflect.java:678)
    at com.sun.proxy.$Proxy68.go (Unknown Source)
    at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7 (ApplicationInformationPanelSkin.java:237)
    at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35)
    at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
    at java.lang.Thread.run (Thread.java:834)

[plata]

Can you find LeagueClient.exe in your container?

[madoar]

For reference:

scripts/Engines/Wine/Shortcuts/Wine/script.js

Line 174 in 8046db2

throw tr("Executable {0} not found!", this._search);

[Zemogiter]

@plata that's a negative

[madoar]

Are there any other .exe files that look like they should be used to start League of Legends?

[Zemogiter]

@madoar no but there is League%20of%20Legends%20installer%20EUW.exe in resources

[plata]

That's only the installer. Apparently something went wrong during installation.

[Zemogiter]

Or maybe Riot changed LeagueClient.exe to something different?

[plata]

Could be. That's why @madoar wrote:

Are there any other .exe files that look like they should be used to start League of Legends?

[Zemogiter]

Tried that exe file from resources in plain wine and it works but it took like a minute between clicking on the file and the installation window to show up. Haven't tested if the game itself works yet

[ImperatorS79]

Did the installer ever run ? It is a graphical installation.

[Zemogiter]

@ImperatorS79 no it did not run

[ImperatorS79]

Then THIS is the actual problem.

[ImperatorS79]

It works for me.

[Zemogiter]

Changing const setupFile to let setupFile didn't fix the problem.

[plata]

Can you try without runtime?

[ImperatorS79]

I did it with runtime and it worked. It seems to be something else then.

[plata]

Only if you're using the same OS and configuration.