fix(preprocessor): handle unquoted Java version string from Bioconda …#231
Open
rkmishra3893 wants to merge 1 commit into
Open
Conversation
…OpenJDK Bioconda's OpenJDK omits quotes in its version output: openjdk 25.0.1-internal 2025-10-21 The previous regex only matched quoted format: openjdk version "17.0.9" 2023-10-17 Updated regex handles both formats. Closes PharmGKB#230
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #230
Bioconda's OpenJDK build outputs its version string without quotes:
openjdk 25.0.1-internal 2025-10-21
The previous regex in
validate_java()only matched the standardquoted format used by Oracle/Temurin:
openjdk version "17.0.9" 2023-10-17
This caused a
ReportableException("Could not find version informationfor Java") even though a fully compatible Java 25 was installed.
Change
One regex line updated in
preprocessor/pcat/utilities.py(~line 218).The new regex handles both quoted and unquoted formats using two
capture groups;
group(1) or group(2)selects whichever matched.Updated regex handles both formats. Closes #230