Skip to content

feat: Add support for metric modulations #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterBjuhr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add support for metric modulations #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions shortscore/musicxml/musicxmlExporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def export_bar(self, glob, bar, bar_number=1):
divs.text = str(divisions)
if glob:
self.create_time_node(attr, glob.get('m'))
self.create_tempomark(glob.get('t'), glob.get('tt'))
self.create_tempomark(glob.get('t'), glob.get('tt'), glob.get('mm'))
self.create_clef(attr, glob.get('c'))
self.parser_tree = self.ssc_parser.parse(lexer, bar)
self.create_nodes_from_parser_objects(self.bar_parent)
Expand Down Expand Up @@ -196,7 +196,9 @@ def create_direction(self, placement='above'):
direction_type = ET.SubElement(direction, 'direction-type')
return direction_type

def create_tempomark(self, tempo, tempotext=None):
def create_tempomark(self, tempo, tempotext=None, metricmod=None):
if metricmod:
self.create_metric_modulation(metricmod)
if tempo:
beat_unit_dot = False
beat_unit, per_minute = tempo.split('=')
Expand All @@ -216,6 +218,26 @@ def create_tempomark(self, tempo, tempotext=None):
pmnode = ET.SubElement(metronome, 'per-minute')
pmnode.text = per_minute

def create_metric_modulation(self, metricmod):
direction_parent = self.create_direction()
metronome = ET.SubElement(direction_parent, 'metronome')
mm_values = metricmod.split('=')
has_same_values = len(mm_values) == 2 and mm_values[0] == mm_values[1]
if not has_same_values:
ET.SubElement(metronome, 'metronome-arrows')
for index, value in enumerate(mm_values):
metronome_note = ET.SubElement(metronome, 'metronome-note')
num_dots = value.count('.')
value_wo_dots = value.replace('.', '')
value_type = Duration.duration_names.get(int(value_wo_dots))
metronome_type = ET.SubElement(metronome_note, 'metronome-type')
metronome_type.text = value_type
for _ in range(num_dots):
ET.SubElement(metronome_note, 'metronome-dot')
if index != len(mm_values) - 1:
metronome_rel = ET.SubElement(metronome, 'metronome-relation')
metronome_rel.text = 'equals'

def create_dynamics(self, parent, dynamic):
if dynamic == '<':
direction_type = self.create_direction('below')
Expand Down