test(ci): close out #8264 — no suite exclusions remain - #8335
Merged
Conversation
added 2 commits
August 18, 2026 00:43
#8333 fixed the last two baseline reds (shadow_slot_hygiene 13/13, typed_feedback 17/17). Remove their SUITE_EXCLUSIONS entries and map both suites; SUITE_EXCLUSIONS is now empty.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#8333 fixed the last two assertions #8264 recorded as baseline reds. Their
SUITE_EXCLUSIONSentries inscripts/ci_e2e_scope.pystayed behind, whichdoes not produce a red build — it produces silence: both suites keep being
skipped in per-PR CI, so the coverage the fix earned back never runs. That is
#7708's failure mode, and it is the same thing #8321 cleaned up after #8302.
SUITE_EXCLUSIONSis now empty.#8264, start to finish
native_proof_buffer_viewsshadow_slot_hygiene::canonical_str_local_keeps_shadow_binding_and_tag_dispatched_opstyped_feedback::typed_feedback_guards_direct_class_field_specializationEight red assertions → zero.
Changes
SUITE_EXCLUSIONSentries.shadow_slot_hygieneandtyped_feedbackto the mapped set —--self-testrefuses a suite that is in neither list, which is what catches the half-done
version of this change.
Validation
Verified on this branch, at the merge of #8333:
python3 scripts/ci_e2e_scope.py --self-test— exit 0scripts/run_lint_gates.sh— all 48 lint-tier gates pass#8264 can be closed once this lands.