fix: resolve parity crash cluster

changelog.d/8272-parity-crashes.md

@@ -0,0 +1,9 @@
+### Fixed
+
+- Fixed `cluster.fork()` HTTP workers losing their worker identity after
+  bootstrap, which prevented shared-port coordination and `listening` events.
+- Fixed a WebAssembly export-call crash by using the standard
+  `WebAssembly.instantiate()` result shape and safe exported-function wrappers.
+- The parity sweep now identifies interactive, server-lifecycle, and
+  external-service fixtures explicitly instead of reporting their expected
+  long-running behavior as runtime crashes.

crates/perry-ext-fastify/src/cluster_bind.rs

@@ -1,10 +1,9 @@
 //! `node:cluster` worker port sharing for the Fastify listen site.
 //!
-//! When this process is a `cluster.fork()`ed worker (Node's convention: a
-//! non-empty `NODE_UNIQUE_ID` in the environment, set by the runtime's
-//! `cluster.fork`), the TCP bind goes through SO_REUSEPORT so N workers can
-//! share one port — the kernel load-balances accepts across them, with no
-//! primary-accept hop. The bound address is reported to the primary over the
+//! When this process is a `cluster.fork()`ed worker, the TCP bind goes through
+//! SO_REUSEPORT so N workers can share one port — the kernel load-balances
+//! accepts across them without a primary-accept hop. The bound address is
+//! reported to the primary over the
 //! cluster IPC so `cluster.on('listening')` fires Node-style.
 //!
 //! This wires Fastify into the cluster machinery that already exists in
@@ -16,13 +15,10 @@
 
 use std::net::{SocketAddr, TcpListener};
 
-/// True when this process is a `cluster.fork()`ed worker (non-empty
-/// `NODE_UNIQUE_ID` in the environment — the same check the runtime and
-/// perry-ext-http use).
+/// True when this process is a `cluster.fork()`ed worker. The runtime caches
+/// this before consuming Node's bootstrap-only `NODE_UNIQUE_ID` variable.
 pub(crate) fn is_cluster_worker() -> bool {
-    std::env::var("NODE_UNIQUE_ID")
-        .map(|s| !s.is_empty())
-        .unwrap_or(false)
+    unsafe { perry_cluster_is_worker() != 0 }
 }
 
 /// Bind `addr` with SO_REUSEPORT (+SO_REUSEADDR) so multiple cluster workers can
@@ -64,6 +60,7 @@ extern "C" {
     // perry-runtime (dev-dep only); the symbol resolves at final link, the same
     // way perry-ffi's runtime helpers do — matching perry-ext-http's
     // `cluster_bind`.
+    fn perry_cluster_is_worker() -> i32;
     fn perry_cluster_worker_listening(
         addr_ptr: *const u8,
         addr_len: u32,

crates/perry-ext-http/src/server/cluster_bind.rs

@@ -1,8 +1,7 @@
 //! #4914 — `node:cluster` worker port sharing for the HTTP/HTTPS/HTTP2
 //! listen sites.
 //!
-//! When this process is a `cluster.fork()`ed worker (Node's convention:
-//! non-empty `NODE_UNIQUE_ID` in the environment), every TCP bind goes
+//! When this process is a `cluster.fork()`ed worker, every TCP bind goes
 //! through SO_REUSEPORT so N workers can share one port, and the bound
 //! address is reported to the primary over the fork IPC channel so
 //! `cluster.on('listening')` fires Node-style. Kernel SO_REUSEPORT
@@ -12,9 +11,7 @@
 use std::net::{SocketAddr, TcpListener};
 
 pub(crate) fn is_cluster_worker() -> bool {
-    std::env::var("NODE_UNIQUE_ID")
-        .map(|s| !s.is_empty())
-        .unwrap_or(false)
+    unsafe { perry_cluster_is_worker() != 0 }
 }
 
 /// Bind `addr`, with SO_REUSEPORT (+SO_REUSEADDR) when running as a cluster
@@ -38,6 +35,7 @@ extern "C" {
     // Defined in perry-runtime's cluster.rs / cluster_sched.rs. This crate has
     // no Cargo dep on perry-runtime (dev-dep only); the symbols resolve at
     // final link, the same way perry-ffi's runtime helpers do.
+    fn perry_cluster_is_worker() -> i32;
     fn perry_cluster_worker_listening(
         addr_ptr: *const u8,
         addr_len: u32,

crates/perry-hir/src/lower/context.rs

@@ -188,7 +188,6 @@ impl LoweringContext {
             proxy_locals: HashSet::new(),
             proxy_local_ids: HashSet::new(),
             builtin_proto_method_locals: HashMap::new(),
-            wasm_instance_locals: HashSet::new(),
             plain_object_locals: HashSet::new(),
             proxy_revoke_locals: HashMap::new(),
             class_expr_aliases: HashMap::new(),

crates/perry-hir/src/lower/expr_call/mod.rs

@@ -77,7 +77,6 @@ mod stream;
 mod textencoder;
 mod url_date_instance;
 mod url_search_params;
-mod wasm_exports;
 
 use array_only_methods::try_array_only_methods;
 use globals::try_global_builtins;
@@ -110,7 +109,6 @@ use regex_string::try_regex_string_methods;
 use static_and_instance::try_static_method_and_instance;
 use textencoder::try_textencoder_decoder;
 use url_date_instance::try_url_date_weakref_instance;
-use wasm_exports::try_wasm_instance_exports;
 
 fn unwrap_call_callee_ts_wrappers(e: &ast::Expr) -> &ast::Expr {
     let mut cur = e;
@@ -568,12 +566,6 @@ fn lower_call_inner(ctx: &mut LoweringContext, call: &ast::CallExpr) -> Result<E
                     Err(a) => a,
                 };
 
-                // `<inst>.exports.<method>(...)` for WebAssembly JS API.
-                args = match try_wasm_instance_exports(ctx, call, expr, args)? {
-                    Ok(e) => return Ok(e),
-                    Err(a) => a,
-                };
-
                 // fs/path/JSON/Math/Number/String/crypto/os/Buffer/cp/net/AbortSignal/Date/URL static methods.
                 args = match try_module_static_methods(ctx, call, expr, args, has_spread)? {
                     Ok(e) => return Ok(e),

crates/perry-hir/src/lower/lowering_context.rs

@@ -702,12 +702,6 @@ pub struct LoweringContext {
     /// rewrite recognize `m.call(arr, ...)` (the receiver of `.call` is a plain
     /// identifier, not a member/literal) and synthesize `arr.map(...)`.
     pub(crate) builtin_proto_method_locals: HashMap<String, String>,
-    /// Issue #76 — locals known to hold a WebAssembly instance handle (i.e.
-    /// `const x = WebAssembly.instantiate(...)`). Used to route
-    /// `x.exports.<method>(...)` to `Expr::WebAssemblyCallExport` only when
-    /// the receiver is a tracked instance, avoiding false matches against
-    /// CJS-style `module.exports.foo()` patterns.
-    pub(crate) wasm_instance_locals: HashSet<String>,
     /// #809: locals whose initializer is an object literal or
     /// `Object.create(...)` — i.e. provably a plain object, never a Date.
     /// Consulted by `static_receiver_class` so `obj.toJSON()` /

crates/perry-hir/src/lower_decl/body_stmt.rs

@@ -170,19 +170,6 @@ pub fn lower_body_stmt(ctx: &mut LoweringContext, stmt: &ast::Stmt) -> Result<Ve
             let mutable = var_decl.kind != ast::VarDeclKind::Const;
             let is_var = var_decl.kind == ast::VarDeclKind::Var;
             for decl in &var_decl.decls {
-                // Issue #76 — pre-tag locals that hold the result of
-                // `WebAssembly.instantiate(...)` so the standard
-                // `inst.exports.<method>(...)` syntactic match in
-                // `lower/expr_call.rs` only fires for genuine wasm
-                // instances (not CJS-style `module.exports.foo()`).
-                if let (ast::Pat::Ident(binding), Some(init_expr)) =
-                    (&decl.name, decl.init.as_deref())
-                {
-                    if init_is_webassembly_instantiate(init_expr) {
-                        ctx.wasm_instance_locals
-                            .insert(binding.id.sym.as_ref().to_string());
-                    }
-                }
                 // Record chained-assignment class self-aliases (`let Logger =
                 // Logger_1 = class …`) so the self-reference isn't captured (see
                 // `synthesize_class_captures`). Function / CJS-module body path.

crates/perry-hir/src/lower_decl/helpers.rs

@@ -53,11 +53,6 @@ pub(super) fn async_iterator_method_call(iterable: Expr) -> Expr {
 /// cross-module callers that pad missing args with `undefined` still observe
 /// the intended default. Rest params are skipped (they're handled by the
 /// call-site array bundling, not by scalar default substitution).
-/// Recognise `WebAssembly.instantiate(...)` call shapes used as a var-decl
-/// initializer. Used to populate `ctx.wasm_instance_locals` so the
-/// standard `inst.exports.<method>(...)` syntactic match in
-/// `lower/expr_call.rs` doesn't fire on unrelated `obj.exports.method()`
-/// calls (notably CJS aggregator output). Issue #76.
 /// Collect local IDs declared anywhere inside this statement tree (Let
 /// statements, for-init Lets, catch-clause variables, etc.) — but do NOT
 /// recurse into nested closures, since those introduce their own scope.
@@ -132,31 +127,6 @@ pub fn collect_let_decls_in_stmt(stmt: &Stmt, out: &mut std::collections::HashSe
     }
 }
 
-pub fn init_is_webassembly_instantiate(expr: &ast::Expr) -> bool {
-    let call = match expr {
-        ast::Expr::Call(c) => c,
-        ast::Expr::Await(a) => return init_is_webassembly_instantiate(&a.arg),
-        _ => return false,
-    };
-    let callee = match &call.callee {
-        ast::Callee::Expr(e) => e.as_ref(),
-        _ => return false,
-    };
-    let member = match callee {
-        ast::Expr::Member(m) => m,
-        _ => return false,
-    };
-    let obj = match member.obj.as_ref() {
-        ast::Expr::Ident(i) => i,
-        _ => return false,
-    };
-    let prop = match &member.prop {
-        ast::MemberProp::Ident(i) => i,
-        _ => return false,
-    };
-    obj.sym.as_ref() == "WebAssembly" && prop.sym.as_ref() == "instantiate"
-}
-
 pub fn build_default_param_stmts(params: &[Param]) -> Vec<Stmt> {
     let mut out: Vec<Stmt> = Vec::new();
     for (idx, param) in params.iter().enumerate() {

crates/perry-hir/src/lower_decl/mod.rs

@@ -52,10 +52,10 @@ pub(crate) use enum_decl::{compute_enum_members, lower_enum_decl};
 pub(crate) use fn_decl::lower_fn_decl;
 pub(crate) use helpers::{
     append_synthetic_arguments_param, body_has_use_strict, body_uses_arguments,
-    build_default_param_stmts, collect_let_decls_in_stmt, init_is_webassembly_instantiate,
-    is_inspect_custom_key, is_symbol_iterator_key, lower_well_known_computed_method,
-    mapped_argument_parameter_ids, params_are_simple_arguments_list, params_use_arguments,
-    symbol_well_known_key, with_static_member_context, WellKnownComputedMethod,
+    build_default_param_stmts, collect_let_decls_in_stmt, is_inspect_custom_key,
+    is_symbol_iterator_key, lower_well_known_computed_method, mapped_argument_parameter_ids,
+    params_are_simple_arguments_list, params_use_arguments, symbol_well_known_key,
+    with_static_member_context, WellKnownComputedMethod,
 };
 pub(crate) use interface_decl::lower_interface_decl;
 pub(crate) use private_members::{

crates/perry-runtime/src/cluster.rs

@@ -81,6 +81,14 @@ pub fn is_cluster_worker() -> bool {
     cluster_worker_id().is_some()
 }
 
+/// Stable cross-crate worker check for the separately linked HTTP/Fastify
+/// adapters. The runtime consumes `NODE_UNIQUE_ID` during cluster bootstrap,
+/// so adapters must query this cached state instead of rereading the env var.
+#[no_mangle]
+pub extern "C" fn perry_cluster_is_worker() -> i32 {
+    is_cluster_worker() as i32
+}
+
 /// Bind a TCP listener with SO_REUSEPORT (+SO_REUSEADDR) so N cluster
 /// workers can share one port (#4914). Callers gate on
 /// [`is_cluster_worker`]; non-worker binds stay on the plain

run_parity_tests.sh

@@ -1287,6 +1287,7 @@ for (( selected_i = 0; selected_i < JOURNAL_TOTAL; selected_i++ )); do
     parity_argv_line=$(sed -n -E 's|^[[:space:]]*//[[:space:]]*parity-argv:[[:space:]]*(.*)$|\1|p' "$test_file" | head -1)
     parity_node_argv_line=$(sed -n -E 's|^[[:space:]]*//[[:space:]]*parity-node-argv:[[:space:]]*(.*)$|\1|p' "$test_file" | head -1)
     parity_env_line=$(sed -n -E 's|^[[:space:]]*//[[:space:]]*parity-env:[[:space:]]*(.*)$|\1|p' "$test_file" | head -1)
+    parity_skip_reason=$(sed -n -E 's|^[[:space:]]*//[[:space:]]*parity-skip:[[:space:]]*(.*)$|\1|p' "$test_file" | head -1)
     test_argv=()
     if [[ -n "$parity_argv_line" ]]; then
         read -r -a test_argv <<< "$parity_argv_line"
@@ -1300,9 +1301,20 @@ for (( selected_i = 0; selected_i < JOURNAL_TOTAL; selected_i++ )); do
         read -r -a parity_env <<< "$parity_env_line"
     fi
 
+    # Lifecycle-driven fixtures (interactive programs, background servers, or
+    # external-service repros) are compile-smoked elsewhere but are not valid
+    # one-shot byte-parity programs. Keep the reason beside the fixture so a
+    # future editor sees why the full sweep must not execute it directly.
+    if [[ -n "$parity_skip_reason" ]]; then
+        echo -e "${YELLOW}SKIP${NC}  $test_id ($parity_skip_reason)"
+        ((SKIPPED++))
+        record_result "$test_id" "skipped"
+        continue
+    fi
+
     # Check if test should be skipped
     if should_skip "$test_name"; then
-        echo -e "${YELLOW}SKIP${NC}  $test_id (async/timer test)"
+        echo -e "${YELLOW}SKIP${NC}  $test_id (suite skip list)"
         ((SKIPPED++))
         record_result "$test_id" "skipped"
         continue

test-files/demo_claude_code_tui.ts

@@ -1,3 +1,4 @@
+// parity-skip: interactive TUI demo; requires terminal input and has no Node oracle
 // Demo: a Claude-Code-style TUI built entirely on perry/tui.
 import {
     Box, Text, Spinner,

test-files/test_fastify_integration.ts

@@ -1,3 +1,4 @@
+// parity-skip: background server; driven by scripts/run_fastify_tests.sh
 // Integration test for Fastify (issue #174). Runs a small server that
 // scripts/run_fastify_tests.sh launches in the background, curls, and
 // asserts the response bodies for each route. Port is read from argv

test-files/test_issue_1240_fastify_request_json.ts

@@ -1,3 +1,4 @@
+// parity-skip: background server; driven by test-files/run_test_issue_1240.sh
 // Issue #1240 — fastify `request.json()` returns `undefined` (silent 400).
 //
 // Before the fix, the native dispatch table routed the `json` method to

test-files/test_issue_1293_fastify_request_json_as_any.ts

@@ -1,3 +1,4 @@
+// parity-skip: background server; driven by test-files/run_test_issue_1293.sh
 // Issue #1293 — fastify `(request as any).json()` / `(request as any).body`
 // returned NaN / undefined (silent 400) under the well-known-flipped
 // perry-ext-fastify backend.

test-files/test_issue_1425_gc_unsafe_zones.ts

@@ -1,3 +1,4 @@
+// parity-skip: background servers; driven by tests/test_issue_1425_gc_unsafe_zones.sh
 // Regression for issue #1425: a long-running Fastify + ws server must not
 // keep the runtime in a process-lifetime GC unsafe zone. Manual gc() calls
 // should run while both servers are listening.

test-files/test_issue_358_perry_tui_phase2_counter.ts

@@ -1,3 +1,4 @@
+// parity-skip: interactive TUI fixture; requires piped keypresses and has no Node oracle
 // Regression test for #358 Phase 2: state + useInput + run loop.
 // Implements the issue's acceptance-criterion #1:
 //

test-files/test_issue_414_mysql_query_params.ts

@@ -1,3 +1,4 @@
+// parity-skip: requires a live MySQL fixture; unit-covered in perry-stdlib
 // Regression test for issue #414:
 // `db.query(sql, [param])` against MySQL failed with `1835 (HY000):
 // Malformed communication packet` and left the connection unusable.

test-files/test_issue_915_jwt_sign_after_async_route.ts

@@ -1,3 +1,4 @@
+// parity-skip: background Fastify server requiring an HTTP client lifecycle
 // Issue #915 regression: jwt.sign after a resumed async Fastify route body
 // must not route through the generic native-module ABI.
 

test-files/test_perry_tui_inkcompat_counter.ts

@@ -1,3 +1,4 @@
+// parity-skip: interactive TUI fixture; requires piped keypresses and has no Node oracle
 // #679 Phase 4 — ink source-compat test #1: counter.
 //
 // The issue's acceptance program (modulo JSX, which is the deferred

test-files/test_perry_tui_inkcompat_useapp.ts

@@ -1,3 +1,4 @@
+// parity-skip: interactive TUI fixture; requires piped keypresses and has no Node oracle
 // #679 Phase 4 — ink source-compat test #2: useApp imperative exit.
 //
 // Validates that `useApp()` returns a stable handle whose `.exit()`

test-files/test_perry_tui_inkcompat_useeffect.ts

@@ -1,3 +1,4 @@
+// parity-skip: interactive TUI fixture; requires piped keypresses and has no Node oracle
 // #679 Phase 4 — ink source-compat test #7: useEffect with deps array.
 //
 // useEffect(fn, []) runs fn once on first render; useEffect(fn) (no

test-files/test_perry_tui_inkcompat_usefocus.ts

@@ -1,3 +1,4 @@
+// parity-skip: interactive TUI fixture; requires piped keypresses and has no Node oracle
 // #679 Phase 4 — ink source-compat test #5: useFocus + Tab cycle.
 //
 // ink's useFocus pattern: multiple form inputs cycle via Tab/Shift-Tab.

test-files/test_perry_tui_inkcompat_usememo.ts

@@ -1,3 +1,4 @@
+// parity-skip: interactive TUI fixture; requires piped keypresses and has no Node oracle
 // #679 Phase 4 — ink source-compat test #6: useMemo caching.
 //
 // useMemo(fn, deps) caches fn() across renders when deps don't change.

test-files/test_perry_tui_inkcompat_useref.ts

@@ -1,3 +1,4 @@
+// parity-skip: interactive TUI fixture; requires piped keypresses and has no Node oracle
 // #679 Phase 4 — ink source-compat test #4: useRef stable handle.
 //
 // ink's useRef pattern: store something the component shouldn't