-
-
Notifications
You must be signed in to change notification settings - Fork 159
fix(next): pass production App Route dylib gate #8082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
proggeramlug
wants to merge
10
commits into
main
Choose a base branch
from
fix/8036-production-app-route
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12,495
−2,301
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bae1357
fix(next): pass production app route dylib gate
a8ff67b
fix: address production app route review
24d5a14
fix(runtime): root bound method construction
16a8fdb
fix(codegen): keep native statepoint roots in app dylibs
8710cd4
chore: split oversized files back under the 2000-line lint cap
1769468
chore: classify the bound-method test hook in the root-holder registry
d0f88f6
feat(gc): name the HOLDERS of a stale from-space address, not just th…
b20337a
fix(runtime): drop this branch's landing-pad regression, and retarget…
6eeb1a5
refactor(gc): sanctioned handle accessors in the bound-method builders
dfd6231
test(next): make the forced-evacuation arm opt-in, tracked by #8163
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| ### Fixed | ||
|
|
||
| - Preserve production Next.js App Route request state through generated | ||
| `AppRouteRouteModule.handle` dispatch, imported handlers, async | ||
| continuations, and separately loaded runtime/stdlib providers (#8036). | ||
|
|
||
| - Keep native statepoint roots in an app dylib. The demotion of | ||
| `--output-type dylib` artifacts to the shared shadow stack predated | ||
| #8081's loaded-image stack-map indexing; with that in place it would | ||
| leave provider apps running a lowering production never ships, and it | ||
| defeated #8081's own gate assertion that the app's map survives macOS | ||
| dead stripping. | ||
|
|
||
| - Class-self lowering respects a same-named method parameter or local | ||
| instead of forcing the lexical class binding; computed `require(".")` / | ||
| `require("..")` resolve relative to the caller; dynamic virtual dispatch | ||
| builds its direct-call ABI from the selected override's own metadata, | ||
| including rest and synthetic `arguments` shape in both override | ||
| directions; bound-method construction roots the receiver across closure | ||
| allocation and the closure across allocating metadata installation; | ||
| malformed unwind-table records are parsed transactionally with checked | ||
| ranges and offsets. | ||
|
|
||
| ### Added | ||
|
|
||
| - A pinned Next 16.3.0 production App Route fixture | ||
| (`tests/release/packages/next-app-route/`): the untouched webpack output | ||
| is compiled as an app-only dylib against separate runtime and stdlib | ||
| provider images, then served through a `dlopen` host and compared with | ||
| the Node production oracle over 10 cold starts, each running two | ||
| 21-request verifier passes. Half the cold starts run under forced | ||
| evacuation with GC diagnostics, and their moving-GC liveness is asserted | ||
| by `scripts/gc_evacuation_liveness_assert.py`, so zero copying minors or | ||
| zero copied objects is a hard failure rather than a vacuous pass. | ||
|
|
||
| - `PERRY_GC_PROTECT_FROMSPACE_HOLDERS=1`: at a from-space fault, sweep the | ||
| whole live heap for any word that still decodes to the faulting address | ||
| and name the owners. The existing report answers "who used it" — the | ||
| consumer, which for a value read out of a table one instruction earlier | ||
| is never the bug; this answers "who kept it". | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the forced-GC release-note claim.
Lines 31-34 state that half of cold starts run under forced evacuation. The default fixture leaves that arm disabled, and the opt-in arm currently fails loudly pending
#8163. Describe it as optional and not part of the default gate.Proposed revision
Based on learnings, changelog fragments must accurately describe shipped behavior.
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Learnings