fix(gc): preserve request graphs across route imports - #8044
fix(gc): preserve request graphs across route imports#8044proggeramlug wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 54 seconds You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
left a comment
There was a problem hiding this comment.
Audited exact head 42bccf62b05911446c614c6c72103d850cfcaac5.
The three source fixes look well-scoped: imported exported-const closures are rooted during argument evaluation, timer ticks root the complete detached expired batch across callbacks/microtasks, and a module's own exported classes are excluded from foreign polymorphic-class augmentation. The focused timer test and the new normal and forced/verified-evacuation parity fixture pass locally.
I am holding the merge because this head says Closes #8036 but does not satisfy that issue's required acceptance gate. #8036 requires the pinned #8034 production AppRouteRouteModule.handle integration, including 20 concurrent GETs and POSTs, normal and forced evacuation, and no direct-handler fallback. The added request-shaped compiler fixture is synthetic and does not run that production route-module path.
Please either add/run the exact production integration gate, or narrow this to a non-closing partial fix. I can re-audit the updated exact head.
Summary
Regression coverage
Testing
Closes #8036